New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: NodeJS 18 compat #275
Conversation
Same here. Thanks for this PR! |
Thanks for this - looking forward to it being merged |
@giralte-ionic is there anything else I can do to move forward? |
Please run |
## [1.7.2](v1.7.1...v1.7.2) (2023-03-02) ### Bug Fixes * NodeJS 18 compat ([#275](#275)) ([45050bb](45050bb))
🎉 This PR is included in version 1.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The iOS deployment was silently failing with NodeJS 18.
The
src/ios/lib/protocol/protocol.ts:sendMessage(msg, callback)
was simply not resolving due to an error while writing on the socket.After adding
I got this logged
So I bumped the
secureProtocol
TLS to v1.2 and it fixes the error and works fine with nodejs 18, 16 and 12