Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use devicectl for iOS 17 if Xcode 15 is available #341

Merged
merged 2 commits into from Sep 21, 2023
Merged

fix: use devicectl for iOS 17 if Xcode 15 is available #341

merged 2 commits into from Sep 21, 2023

Conversation

jcesarmobile
Copy link
Member

closes #320

@jcesarmobile jcesarmobile merged commit 5c56d71 into develop Sep 21, 2023
5 checks passed
@jcesarmobile jcesarmobile deleted the devicectl branch September 21, 2023 15:26
github-actions bot pushed a commit that referenced this pull request Sep 21, 2023
@Ionitron
chore(release): 1.7.3 [skip ci]
991c5e5 
## [1.7.3](v1.7.2...v1.7.3) (2023-09-21)

### Bug Fixes

* Pin @types/babel__traverse version to fix build ([#342](#342)) ([8492b24](8492b24))
* use devicectl for iOS 17 if Xcode 15 is available ([#341](#341)) ([5c56d71](5c56d71))
@capc0
Copy link
Contributor

capc0 commented Oct 19, 2023

For me this does not work, even tho Xcode 15 is installed.

I think the version extraction is wrong:

const [xcodeVersion] = getXcodeVersionInfo();
if (Number(xcodeVersion) >= 15) {

because Number("15.0.1") will result in NaN.

This was referenced Oct 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markemer markemer markemer approved these changes

@giralte-ionic giralte-ionic giralte-ionic approved these changes

@theproducer theproducer Awaiting requested review from theproducer

@IT-MikeS IT-MikeS Awaiting requested review from IT-MikeS

@ItsChaceD ItsChaceD Awaiting requested review from ItsChaceD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS 17 Support needed.
4 participants
@jcesarmobile @capc0 @markemer @giralte-ionic