Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xcode major version extraction #351

Merged
merged 1 commit into from Oct 24, 2023
Merged

Conversation

capc0
Copy link
Contributor

@capc0 capc0 commented Oct 19, 2023

@biesbjerg
Copy link

Verified — fixes the problem for me as well!

[capacitor] [error] ERR_UNKNOWN: running on iOS 17 devices requires Xcode 15 and later

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

I pick the code from another check where it was checking with < 10, so looks like that check has never worked.

@jcesarmobile jcesarmobile merged commit 24ffe66 into ionic-team:develop Oct 24, 2023
5 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 24, 2023
## [1.7.4](v1.7.3...v1.7.4) (2023-10-24)

### Bug Fixes

* xcode major version extraction ([#351](#351)) ([24ffe66](24ffe66))
@Ionitron
Copy link
Collaborator

🎉 This PR is included in version 1.7.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants