fix(): back-compatibility with old stencil runtime

ionic-team · Jun 27, 2019 · 10a5704 · 10a5704
1 parent 91fb61d
commit 10a5704
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/runtime/connected-callback.ts b/src/runtime/connected-callback.ts
@@ -65,7 +65,7 @@ export const connectedCallback = (elm: d.HostElement, cmpMeta: d.ComponentRuntim
         while ((ancestorComponent = (ancestorComponent.parentNode as any || ancestorComponent.host as any))) {
           // climb up the ancestors looking for the first
           // component that hasn't finished its lifecycle update yet
-          if ((BUILD.hydrateClientSide && ancestorComponent.nodeType === NODE_TYPE.ElementNode && ancestorComponent.hasAttribute('s-id')) || (ancestorComponent['s-init'] && !ancestorComponent['s-lr'])) {
+          if ((BUILD.hydrateClientSide && ancestorComponent.nodeType === NODE_TYPE.ElementNode && ancestorComponent.hasAttribute('s-id')) || (ancestorComponent['s-init'] && ancestorComponent['s-lr'] === false)) {
             // we found this components first ancestor component
             // keep a reference to this component's ancestor component
             hostRef.$ancestorComponent$ = ancestorComponent;

diff --git a/src/runtime/initialize-component.ts b/src/runtime/initialize-component.ts
@@ -85,7 +85,7 @@ export const initializeComponent = async (elm: d.HostElement, hostRef: d.HostRef
 
   // we've successfully created a lazy instance
   const ancestorComponent = hostRef.$ancestorComponent$;
-  if (BUILD.lifecycle && BUILD.lazyLoad && ancestorComponent && !ancestorComponent['s-lr'] && ancestorComponent['s-rc']) {
+  if (BUILD.lifecycle && BUILD.lazyLoad && ancestorComponent && ancestorComponent['s-lr'] === false && ancestorComponent['s-rc']) {
     // this is the intial load and this component it has an ancestor component
     // but the ancestor component has NOT fired its will update lifecycle yet
     // so let's just cool our jets and wait for the ancestor to continue first