fix(angular): property assignment happens after append (#1732)

* fix(angular): property assignment happens after append * fix naming
ionic-team · Jul 16, 2019 · 4a3982d · 4a3982d
1 parent 0459e22
commit 4a3982d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/src/compiler/app-core/build-conditionals.ts b/src/compiler/app-core/build-conditionals.ts
@@ -117,6 +117,7 @@ export function updateBuildConditionals(config: d.Config, b: d.Build) {
   b.member = (b.member || b.updatable || b.mode || b.lifecycle);
   b.taskQueue = (b.updatable || b.mode || b.lifecycle);
   b.constructableCSS = !b.hotModuleReplacement || !!config._isTesting;
+  b.initializeNextTick = true; // config.outputTargets.some(isOutputTargetAngular);
   b.cssAnnotations = true;
 }
 

diff --git a/src/declarations/build-conditionals.ts b/src/declarations/build-conditionals.ts
@@ -86,6 +86,7 @@ export interface Build extends Partial<BuildFeatures> {
   profile?: boolean;
   cssVarShim?: boolean;
   constructableCSS?: boolean;
+  initializeNextTick?: boolean;
 }
 
 export interface UserBuildConditionals {

diff --git a/src/runtime/connected-callback.ts b/src/runtime/connected-callback.ts
@@ -90,7 +90,7 @@ export const connectedCallback = (elm: d.HostElement, cmpMeta: d.ComponentRuntim
         });
       }
 
-      if (BUILD.taskQueue && BUILD.mode) {
+      if (BUILD.initializeNextTick) {
         // connectedCallback, taskQueue, initialLoad
         // angular sets attribute AFTER connectCallback
         // https://github.com/angular/angular/issues/18909