fix(testing): more consistent screenshots

ionic-team · Oct 8, 2019 · ad42326 · ad42326
1 parent 9623efb
commit ad42326
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/src/compiler/config/test/validate-testing.spec.ts b/src/compiler/config/test/validate-testing.spec.ts
@@ -61,7 +61,6 @@ describe('validateTesting', () => {
     validateConfig(config, [], false);
     expect(config.testing.browserArgs).toEqual([
       '--font-render-hinting=medium',
-      '--enable-font-antialiasing',
       '--no-sandbox',
       '--disable-setuid-sandbox',
       '--disable-dev-shm-usage',
@@ -73,7 +72,6 @@ describe('validateTesting', () => {
     validateConfig(config, [], false);
     expect(config.testing.browserArgs).toEqual([
       '--font-render-hinting=medium',
-      '--enable-font-antialiasing',
     ]);
   });
 

diff --git a/src/compiler/config/validate-testing.ts b/src/compiler/config/validate-testing.ts
@@ -22,7 +22,6 @@ export function validateTesting(config: d.Config, diagnostics: d.Diagnostic[]) {
 
   testing.browserArgs = testing.browserArgs || [];
   addOption(testing.browserArgs, '--font-render-hinting=medium');
-  addOption(testing.browserArgs, '--enable-font-antialiasing');
 
   if (config.flags.ci) {
     addOption(testing.browserArgs, '--no-sandbox');

diff --git a/src/testing/puppeteer/puppeteer-screenshot.ts b/src/testing/puppeteer/puppeteer-screenshot.ts
@@ -87,11 +87,9 @@ export async function pageCompareScreenshot(page: pd.E2EPageInternal, env: d.E2E
   await wait(screenshotBuildData.timeoutBeforeScreenshot);
   await page.evaluate(() => {
     return new Promise(resolve => {
-      (window as any).requestIdleCallback(() => {
-        window.requestAnimationFrame(() => {
-          resolve();
-        });
-      }, { timeout: 100 });
+      window.requestAnimationFrame(() => {
+        resolve();
+      });
     });
   });
 
@@ -109,7 +107,7 @@ function createPuppeteerScreenshopOptions(opts: d.ScreenshotOptions) {
     type: 'png',
     fullPage: opts.fullPage,
     omitBackground: opts.omitBackground,
-    encoding: 'binary'
+    encoding: 'binary',
   };
 
   if (opts.clip) {