-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prerender not finding window properties #1036
Comments
Currently prerendering is getting refactored to use |
Cool I'm also getting some redux properties errors: Runtime error detected during componentWillLoad(): create-grow-view
Cannot read property 'subscribe' of undefined TypeError: Cannot read property 'subscribe' of undefined at
Object.mapStateToProps (evalmachine.<anonymous>:3:575) at t.initRedux (evalmachine.<anonymous>:2:17837) at
t.componentWillLoad (evalmachine.<anonymous>:2:17688) at update
(/Users/digo/code/src/gitlab.com/threeaccents/soli/webapp/node_modules/@stencil/core/dist/compiler/index.js:10519:48)
at plt.queue.tick
(/Users/digo/code/src/gitlab.com/threeaccents/soli/webapp/node_modules/@stencil/core/dist/compiler/index.js:10477:34)
at flush
(/Users/digo/code/src/gitlab.com/threeaccents/soli/webapp/node_modules/@stencil/core/dist/compiler/index.js:11946:33)
at _combinedTickCallback (internal/process/next_tick.js:131:7) at process._tickCallback
(internal/process/next_tick.js:180:9) |
just ran into this with https://github.com/balupton/stencil-ssr-on-zeit-now didn't puppeteer get canned? How extensive is the puppeteer plan? Adopting puppeteer could eliminate serverless (e.g. ziet now, cloudflare works) rendering of stencil components/pages/apps — which will be a growing environment for SSR, due to its cost, scaling, and speed benefits. Unfortunately for me, I can't adopt stencil until it supports serverless rendering. Considering SSR is completely broken right now, it would be nice if it this was reflected here: |
Stencil one will be able to support window/document usage thanks to V8's VM isolation! where we can execute your app under different context (globals). |
Stencil version:
I'm submitting a:
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/
Current behavior:
When running
npm run build
I get lots of error's sayingwindow
properties couldn't be found. This only happens in the prerender step.Expected behavior:
Window properties should be found and no compile error should be thrown.
Steps to reproduce:
Use
window
properties somewhere the code and try to compile the app with prerender.Related code:
Other information:
The text was updated successfully, but these errors were encountered: