feat(mock-doc): add NodeList #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer needs to have NodeList on MockWindow.
The customer's tests fail when they try to test a Stencil component that itself uses tippy.js. Here is where it is failing with a ReferenceError because NodeList is not found, so that is essentially what I am trying to duplicate in the test w/o actually including tippy.js.
Here is the LOC in tippy.js that results in the failure in the Stencil component unit test:
https://github.com/atomiks/tippyjs/blob/8b23e4a51452b89ca9a54731bb499eac4cc2920e/src/ponyfills.ts#L3
This PR adds NodeList to MockWindow in order to facilitate these tests.