-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refresh broken in 1.1.3 #1696
Comments
I don't understand the issue, is it broken? is it slow? |
I would say broken compared to previous. |
Try to find the root of the problem, when you see it not working, what is failing? |
I can try to step forward from 1.1.2 NOTE: It is not specific to Android. I also appears on the website and local testing on Chrome. I just tested with iPhone 6, software version 12.3.1 and it is not a problem with Safari. Drag down with the finger on the screen does nothing and hit refresh for the site works fine. I checked and there are no interim releases between 1.1.2 and 1.1.3 @manucorporat Please confirm the issue for Android with the site link provided so I can revert to a known good baseline. It can be considered for further debugging on my side in the event that it is not resolved for the next release. |
@manucorporat I have this code: <script src="https://unpkg.com/@ionic/core@4.6.0/dist/ionic.js"></script>It may be related. TBD Does Ionic have an alternate CDN that could be switched to based on response time? |
Looks like the CDN was the cause.
Fixed here: https://github.com/adaept/ae-icons-component/releases/tag/v4.6.1%2F1.1.3%2F0.3.3 |
Stencil version:
I'm submitting a:
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/
Current behavior:
Refresh is broken.
Expected behavior:
Steps to reproduce:
Here: https://aeicons.adaept.com
app loads
pull down to refresh and it does not work (drag finger down on the screen)
tested on my android phone LG K20 V, Android 7.0
after a few minutes it may work again once or it may not
Related code:
Repo: adaept/ae-icons-component@1fefcec
Added better version info: core/ionicons/stencil/component
// insert any relevant code here
Other information:
It is working in 1.1.2 but the reload seems slower than before:
https://github.com/adaept/ae-icons-component/tree/Branch_ae0162cd
@manucorporat
After testing to resolve the changes it appears stencil 1.1.3 is causing the issue.
Could the manifest now be an issue/requirement where it did not cause problems before?
The text was updated successfully, but these errors were encountered: