New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vdom): add dev check for unexpected vnode #1950

Merged

manucorporat merged 1 commit into master from add-wrong-vnode-check

Oct 14, 2019

Contributor

manucorporat commented Oct 14, 2019


          fix(vdom): add dev check for unexpected vnode

ae26d31

manucorporat merged commit 358e925 into master

adamdbradley deleted the add-wrong-vnode-check branch

October 15, 2019 22:06

mikaelkaron reviewed

View reviewed changes

src/runtime/vdom/h.ts

                     } else if (child != null && typeof child !== 'boolean') {
                       if (simple = typeof nodeName !== 'function' && !isComplexType(child)) {
                         child = String(child);
+                      } else if (BUILD.isDev && child.$flags$ === undefined) {

mikaelkaron Oct 16, 2019

is it possible child could have been a string?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment