Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime): render svg #text nodes #2176

Merged
merged 2 commits into from
Feb 2, 2020
Merged

fix(runtime): render svg #text nodes #2176

merged 2 commits into from
Feb 2, 2020

Conversation

manucorporat
Copy link
Contributor

Text nodes inside <svg> are possible, look at the <text> tag:

<svg>
  <text>Message</text>
</svg>

#text nodes are not SVG elements and their ownerSVGElement is undefined, however that does not mean the vdom render left the SVG, so isSvgMode should still be true after rendering a text node.

This breaks SVG rendering after the first #text node

@manucorporat manucorporat merged commit 4582183 into master Feb 2, 2020
@manucorporat manucorporat deleted the fix-svg-text-nodes branch February 2, 2020 15:50
adamdbradley pushed a commit that referenced this pull request Feb 4, 2020
@manucorporat @adamdbradley
fix(runtime): render svg #text nodes (#2176)
f623bf7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@manucorporat