Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs-custom): add config argument #2696

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

jgroth
Copy link
Contributor

@jgroth jgroth commented Oct 7, 2020

I would like to have access to the logger when using the docs-custom output target, at the moment only the docs generated by Stencil is given to the generator function.

Sending only the logger to generator seems a bit weird and since the logger is available on config I added that as an argument instead. There might be other stuff on config that also could be of use to anyone using the docs-custom output target.

If there is another way to do this, please let med know! 馃檪
I'm also not sure if there is anything else I need to update, all the tests pass at least! 馃檪

@adamdbradley adamdbradley merged commit d285879 into ionic-team:master Oct 14, 2020
@adamdbradley
Copy link
Contributor

looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants