Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallbacked slots inside Light DOM are broken #2760

Closed
dahfazz opened this issue Dec 4, 2020 · 4 comments
Closed

Fallbacked slots inside Light DOM are broken #2760

dahfazz opened this issue Dec 4, 2020 · 4 comments

Comments

@dahfazz
Copy link

dahfazz commented Dec 4, 2020

Stencil version:

 @stencil/core@2.3.0

I'm submitting a:

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:

Fallbacked slots are not working anymore. (on any browser)

Expected behavior:

When using a slot in a Light DOM stencil component, the default value set inside component slot is not replaced by slot content given by component consumer.
Instead, the content is happened eight after the fb-slot but, fb-slot remains visible.

Steps to reproduce:

Related code:

// insert any relevant code here

Other information:

@claviska claviska added the bug label Dec 4, 2020
@claviska
Copy link
Contributor

claviska commented Dec 4, 2020

Just tested a few things and here's what I'm seeing.

Example Component

import { Component, h } from '@stencil/core';

@Component({
  tag: 'my-component',
  shadow: false,
})
export class MyComponent {
  render() {
    return <slot>FALLBACK</slot>;
  }
}

HTML

  <my-component></my-component>

  <br><br>

  <my-component>SLOTTED</my-component>

Expected

FALLBACK

SLOTTED

Actual

FALLBACK

FALLBACKSLOTTED

This is with Stencil 2.3.0 and only occurs with shadow: false. Can you confirm this is what you're seeing?

@claviska
Copy link
Contributor

claviska commented Dec 4, 2020

If this is indeed what you're seeing, then #2650 fixes it and will be available in the next release.

@dahfazz
Copy link
Author

dahfazz commented Dec 6, 2020

If this is indeed what you're seeing, then #2650 fixes it and will be available in the next release.

This is exactly what I can see.
Good news for #2650 fix
Tks!

@ionitron-bot ionitron-bot bot added the ionitron: stale issue This issue has not seen any activity for a long period of time label Jan 5, 2021
@ionitron-bot
Copy link

ionitron-bot bot commented Jan 5, 2021

Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of Stencil, please create a new issue and ensure the template is fully filled out.

Thank you for using Stencil!

@ionitron-bot ionitron-bot bot closed this as completed Jan 5, 2021
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jan 5, 2021
@claviska claviska removed the ionitron: stale issue This issue has not seen any activity for a long period of time label Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants