Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vdom): prevent error for parentless nodes #2761

Merged
merged 2 commits into from
Dec 16, 2020
Merged

fix(vdom): prevent error for parentless nodes #2761

merged 2 commits into from
Dec 16, 2020

Conversation

claviska
Copy link
Contributor

@claviska claviska commented Dec 4, 2020

Fixes #2758

@claviska claviska added the bug label Dec 4, 2020
@claviska claviska self-assigned this Dec 4, 2020
eriklharper
eriklharper approved these changes Dec 5, 2020
View reviewed changes
Copy link

@eriklharper eriklharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@claviska
Copy link
Contributor Author

claviska commented Dec 5, 2020

So this seems to fix the test case but some of the Karma tests are failing. I’ll look into that more on Monday.

@chenyulun chenyulun mentioned this pull request Dec 11, 2020
Closed
@adamdbradley adamdbradley merged commit a08f3a8 into master Dec 16, 2020
@adamdbradley adamdbradley deleted the slot-relocation-error branch December 16, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriklharper eriklharper eriklharper approved these changes

@adamdbradley adamdbradley Awaiting requested review from adamdbradley

Assignees

@claviska claviska

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node.parentNode value is null when relocating slot content in certain cases
3 participants
@claviska @eriklharper @adamdbradley