fix(worker-plugin): transfer OffscreenCanvas #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could we make it a small utility function? like |
The problem is that the check is used in two separated contexts, one is in the "getWorkerIntro" which is attached to the worker, and the other is in the "WORKER_HELPERS" which is attached to the file that instantiates the worker. |
|
ah you right! merging i am actually thinking of using getTransferables in both contexts |
johnjenkins
pushed a commit
to johnjenkins/stencil
that referenced
this pull request
Apr 8, 2021
Co-authored-by: Arsen Pellumbi <apellumbi@screeningsolution.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2848