fix(mock-doc): allow urls as css values #2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks legit, it might be interesting to add a new failing test, but so far makes sense! |
Added tests |
rwaskiewicz
approved these changes
Dec 7, 2021
|
Thanks! |
rwaskiewicz
added
the
Resolution: Refine
|
(sorry for the spam, labeling this so that I can get it ingested in our internal issue/release tracker) |
|
This fix has been included in the v2.12.0 release. I'm going to close this issue, however if the problem reappears, please feel free to open a new issue! |
rwaskiewicz
added
Resolution: Shipped
and removed
Resolution: Refine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS values such as
background-image: (https://mydomain.com/image.jpg)currently loses values after the second colon. This ensures the entire value is taken into account when a url is specified.