Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add referrerPolicy to AnchorHTMLAttributes #3006

Conversation

wavebeem
Copy link
Contributor

Add referrerPolicy to AnchorHTMLAttributes

Fixes #2933

@wavebeem wavebeem requested a review from a team August 17, 2021 21:33
Copy link
Member

@rwaskiewicz rwaskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rwaskiewicz rwaskiewicz merged commit 4f7c073 into ionic-team:master Aug 31, 2021
@rwaskiewicz
Copy link
Member

A quick note - the team is considering this a non-breaking change, as this shouldn't affect most folks using these types. For those that are doing type manipulations that stripping the optional aspect of this interface (e.g. type myType = Required<AnchorHTMLAttributes>), and are not specifying the referrerPolicy today in any way, set referrerPolicy to strict-origin-when-cross-origin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute referrerPolicy is missing on AnchorHTMLAttributes
2 participants