Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Typescript interface SVGAttributes is not correct declared for attribute color-interpolation-filters #3354

Closed
fbrandel opened this issue May 4, 2022 · 3 comments · Fixed by #4530
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil

Comments

@fbrandel
Copy link

fbrandel commented May 4, 2022

Stencil version:

 @stencil/core@2.15.1

Current behavior:

Typescript interface SVGAttributes is not correct declared for attribute color-interpolation-filters. Contains values "s-rGB" and "linear-rGB" instead.

<filter color-interpolation-filters="sRGB" .../>

[ ERROR ]  TypeScript: ./src/components/...
           Type '{ id: string; x: string; y: string; width: string; height: string; filterUnits: string;
           "color-interpolation-filters": "sRGB"; }' is not assignable to type 'SVGAttributes<SVGElement>'.Types of
           property ''color-interpolation-filters'' are incompatible.Type '"sRGB"' is not assignable to type '"auto" |
           "inherit" | "s-rGB" | "linear-rGB"'. Did you mean '"s-rGB"'?

Expected behavior:
Attribute color-interpolation-filters is typed with correct values "sRGB" and "linearRGB"

@ionitron-bot ionitron-bot bot added the triage label May 4, 2022
@fbrandel fbrandel changed the title Typescript interface SVGAttributes is not correct declared for attribute color-interpolation-filters bug: Typescript interface SVGAttributes is not correct declared for attribute color-interpolation-filters May 4, 2022
@rwaskiewicz rwaskiewicz added the ionitron: needs reproduction This PR or Issue does not have a reproduction case URL label May 4, 2022
@ionitron-bot
Copy link

ionitron-bot bot commented May 4, 2022

Thanks for the issue! This issue has been labeled as needs reproduction. This label is added to issues that need a code reproduction.

Please reproduce this issue in an Stencil starter component library and provide a way for us to access it (GitHub repo, StackBlitz, etc). Without a reliable code reproduction, it is unlikely we will be able to resolve the issue, leading to it being closed.

If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was not enough for our team to reproduce the issue.

For a guide on how to create a good reproduction, see our Contributing Guide.

@ionitron-bot ionitron-bot bot removed the triage label May 4, 2022
@rwaskiewicz
Copy link
Member

I gave this a second read through, and it appears this is concerning the Mock Doc. Sorry about that! I'm going to label this to be ingested into the team's backlog

@rwaskiewicz rwaskiewicz added Bug: Validated This PR or Issue is verified to be a bug within Stencil and removed ionitron: needs reproduction This PR or Issue does not have a reproduction case URL labels May 19, 2022
@rwaskiewicz
Copy link
Member

The fix for this issue has been released as a part of today's Stencil v4.0.2 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants