Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: SOURCEMAP_ERROR reported with dist-hydate-script + dist-custom-elements #4260

Closed
3 tasks done
rwaskiewicz opened this issue Apr 12, 2023 · 3 comments · Fixed by #4527
Closed
3 tasks done

bug: SOURCEMAP_ERROR reported with dist-hydate-script + dist-custom-elements #4260

rwaskiewicz opened this issue Apr 12, 2023 · 3 comments · Fixed by #4527
Assignees
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil

Comments

@rwaskiewicz
Copy link
Member

rwaskiewicz commented Apr 12, 2023

Prerequisites

Stencil Version

3.2.1

Current Behavior

When building a Stencil project that includes both dist-custom-elements and dist-hydrate-script in it's stencil.config.ts#outputTargets field, a warning is reported during the build:

[ WARN  ]  Bundling Warning SOURCEMAP_ERROR
           Error when using sourcemap for reporting an error: Can't resolve original location of error.

Expected Behavior

No warning is shown/caused

System Info

$ npx stencil info
      System: node 18.14.2
    Platform: darwin (22.2.0)
   CPU Model: Apple M1 (8 cpus)
    Compiler: /private/tmp/dist-hydrate-script-sourcemap-warn/node_modules/@stencil/core/compiler/stencil.js
       Build: 1681148889
     Stencil: 3.2.1 🎙
  TypeScript: 4.9.5
      Rollup: 2.42.3
      Parse5: 7.1.2
      Sizzle: 2.42.3
      Terser: 5.16.8
$ npm --version
8.19.4

Steps to Reproduce

  1. Clone the repository in the code reproduction URL field the locally
  2. npm ci
  3. npm run build
  4. Observe the output descripted in "Current Behavior"

Note: These steps are also captured in the reproduction's README

Code Reproduction URL

https://github.com/rwaskiewicz/stencil-dist-hydrate-script-sourcemap-warn

Additional Information

This issue was created in response to #3165. It appears that the issue is fixed in the reproduction that was provided, but not necessarily completely squashed

@ionitron-bot ionitron-bot bot added the triage label Apr 12, 2023
@rwaskiewicz rwaskiewicz self-assigned this Apr 12, 2023
@rwaskiewicz rwaskiewicz changed the title bug: SOURCEMAP_ERROR reported with dist-hydate-script + www bug: SOURCEMAP_ERROR reported with dist-hydate-script + dist-custom-elements Apr 12, 2023
@rwaskiewicz rwaskiewicz added the Bug: Validated This PR or Issue is verified to be a bug within Stencil label Apr 12, 2023
@ionitron-bot ionitron-bot bot removed the triage label Apr 12, 2023
@rwaskiewicz
Copy link
Member Author

For anyone running into this issue, can you please try installing the following dev build and let me know how it goes?

npm i @stencil/core@4.0.1-dev.1688045194.5d2dda3

@dgonzalezr
Copy link

Hello @rwaskiewicz confirming here as well after leaving a comment in #3165 🙂

I can confirm the issue is fixed after testing with the @stencil/core@4.0.1-dev.1688045194.5d2dda3 version 🥳

image

CleanShot 2023-07-05 at 19 35 35

@rwaskiewicz
Copy link
Member Author

The fix for this issue has been released as a part of today's Stencil v4.0.2 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants