Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: DialogHTMLAttributes does not contain onCancel event #4267

Closed
3 tasks done
FabioGimmillaro opened this issue Apr 14, 2023 · 2 comments
Closed
3 tasks done

bug: DialogHTMLAttributes does not contain onCancel event #4267

FabioGimmillaro opened this issue Apr 14, 2023 · 2 comments
Assignees
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil

Comments

@FabioGimmillaro
Copy link

Prerequisites

Stencil Version

2.22.3

Current Behavior

The DialogHTMLAttribute definition does not contain the onCancel event of the dialog element.

Expected Behavior

The onCancel event is defined and can be used

System Info

Irrelevant

Steps to Reproduce

Create a new Stencil-Project
Add a new component.

Add following code to the render-function:

return <dialog onCancel={(e) => console.log(e)}></dialog>

=> "Type '{ onCancel: (e: any) => void; }' is not assignable to type 'DialogHTMLAttributes'"

Code Reproduction URL

https://github.com/bassettsj/stencil-dialog-element-bug

Additional Information

I checked for other issues and there is one which was resolved 3 years ago: #1049
The "Code Reproduction URL" within my issue is copied from the old issue.

Unfortunately this doesn't work for our current StencilJS version.
I also checked on your main branch which also doesn't define onCancel within the stencil-public-runtime file:

export interface DialogHTMLAttributes<T> extends HTMLAttributes<T> {

@ionitron-bot ionitron-bot bot added the triage label Apr 14, 2023
@tanner-reits tanner-reits self-assigned this Apr 14, 2023
@tanner-reits
Copy link
Member

Hey @FabioGimmillaro 👋

Thanks for reporting this issue! I was able to confirm that the bindings for onClose and onCancel are not available on the dialog element. I'll get this labeled to be added to our backlog!

@tanner-reits tanner-reits added Bug: Validated This PR or Issue is verified to be a bug within Stencil and removed triage labels Apr 14, 2023
@rwaskiewicz
Copy link
Member

👋

The fix for this issue has been included in the 🏒 v3.2.2 release of Stencil, which was released earlier today. As a result, I'm going to close this issue. Should it reappear, please feel free to open a new issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil
Projects
None yet
Development

No branches or pull requests

3 participants