Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: type import paths are invalid for dist-custom-elements if dir matches location of types output location #4630

Closed
3 tasks done
tanner-reits opened this issue Jul 27, 2023 · 2 comments · Fixed by #4633
Closed
3 tasks done
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil

Comments

@tanner-reits
Copy link
Member

Prerequisites

Stencil Version

4.0.2

Current Behavior

If you configure the dist-custom-elements output target to write to the default output location for Stencil (i.e. dist), the import paths for typedefs results in an invalid path:

{
  type: 'dist-custom-elements',
  dir: 'dist'
}

Results in import paths like: .types/components

Expected Behavior

A config like this should result in a valid path like: ./types/components

System Info

No response

Steps to Reproduce

Set this dir property on the dist-custom-elements output target in a Stencil component starter to dist

Code Reproduction URL

https://github.com/ionic-team/stencil-component-starter

Additional Information

No response

@D4RKAR117
Copy link

Same behavior around here, the path must be at least in my case export * from './types' on index.d.ts but instead i get export * from '.types' the / is missing

@tanner-reits
Copy link
Member Author

This was resolved in Stencil v4.0.3. Please re-open this issue if you are still experiencing issues after updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants