Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review new file creation and add to project #147

Open
mlynch opened this issue Dec 20, 2022 · 1 comment
Open

Review new file creation and add to project #147

mlynch opened this issue Dec 20, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@mlynch
Copy link
Contributor

mlynch commented Dec 20, 2022

There are a few more filetypes that #144 didn't handle, namely xml and json (and others in the future). Review how to handle those other files that can be cross-platform and think of a long term strategy here

@mlynch mlynch added the enhancement New feature or request label Dec 20, 2022
@vscaiceanu-1a
Copy link

Hi @mlynch

I've added a commit to reproduce an use-case for localizing app names for Android

victorsc/trapeze-issues@bf11d03

values-fr/strings.xml exists and the attrubutes are correctly updated.
values-de/strings.xml doesn't and the xml file isn't created on the fly.

In this case, there's no need to add the newly created file to the project (as it is the case for .strings files for iOS. If I manually add the file and rebuild my Android project I can see the localized app name.

With this fix, Trapeze will fully support white label app name localization for both iOS and Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants