Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS buildNumber is parsed as number #168

Closed
DavidStrausz opened this issue Feb 10, 2023 · 6 comments
Closed

iOS buildNumber is parsed as number #168

DavidStrausz opened this issue Feb 10, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@DavidStrausz
Copy link

The following commit introduced forced number parsing:
ba5f8f2

This is breaking and causes incorrect build numbers for projects that use build numbers that are in sync with the version (e.g. 1.0.0) instead of incrementing an integer (in this case 1.0.0 would be parsed as 1).

@mlynch
Copy link
Contributor

mlynch commented Feb 11, 2023

Okay I'll need to go back to the drawing board with this one, thanks for the heads up

@mlynch mlynch added the bug Something isn't working label Feb 11, 2023
@mlynch
Copy link
Contributor

mlynch commented Feb 12, 2023

@DavidStrausz what would you expect to happen here? Nothing, or semver increment?

@DavidStrausz
Copy link
Author

@mlynch Nothing I'd say, any logic regarding build numbers and other values should be handled by ci/cd scripts (e.g. faslane), and trapeze just applies the values set in config.yaml/env vars

@mlynch
Copy link
Contributor

mlynch commented Feb 12, 2023

Ah nevermind, you aren't using this with increment. I got it

@mlynch mlynch closed this as completed in c3c7e4f Feb 13, 2023
@mlynch
Copy link
Contributor

mlynch commented Feb 13, 2023

Fixed in 7.0.8. Also fwiw Android versionCode only supports integers, so this fix was just for iOS

@DavidStrausz
Copy link
Author

I just updated and it's working as expected again! And yes you are right about the Android versionCode property.
Thank you, and great package btw! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants