Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote strings before updating pbx #37

Closed
mlynch opened this issue Dec 15, 2021 · 2 comments
Closed

Quote strings before updating pbx #37

mlynch opened this issue Dec 15, 2021 · 2 comments

Comments

@mlynch
Copy link
Contributor

mlynch commented Dec 15, 2021

Some pbx parsers are sensitive about strings being quoted (like the one used by cocoapods) and we're currently not quoting strings when writing back
@geoff-schultz
Copy link

Yes running into this issue now with PRODUCT_NAME in the project.pbxproj file needing quotes when running the cap sync or pod install commands.

@mlynch mlynch closed this as completed in 9bfb74d Apr 13, 2022
@mlynch
Copy link
Contributor Author

mlynch commented Apr 13, 2022 •
edited

Fixed this. It will always read values without quotes, and write values that "need" to be quoted with quotes (based on the limited information around what values actually need to be quoted for pbx files, ex: http://danwright.info/blog/2010/10/xcode-pbxproject-files/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mlynch @geoff-schultz