feat(rules): add ion-item-divider-ion-label-required rule (#36)

README.md

@@ -306,11 +306,13 @@ We are looking for contributors to help build these rules out! See [`CONTRIBUTIN
       <a href="https://github.com/ionic-team/ionic/blob/master/angular/BREAKING.md#item-divider">Item Divider</a>
     </th>
     <td></td>
-    <td>:white_large_square:</td>
+    <td>:white_check_mark:</td>
     <td>
       <code>ion-item-divider-ion-label-required</code>
     </td>
-    <td></td>
+    <td>
+      <a href="https://github.com/dwieeb">@dwieeb</a>
+    </td>
   </tr>
   <tr>
     <th>

src/ionItemDividerIonLabelRequiredRule.ts

@@ -0,0 +1,29 @@
+import { NgWalker } from 'codelyzer/angular/ngWalker';
+import * as Lint from 'tslint';
+import * as ts from 'typescript';
+
+import { createIonLabelRequiredTemplateVisitorClass } from './helpers/ionLabelRequired';
+
+export const ruleName = 'ion-item-divider-ion-label-required';
+
+const TemplateVisitor = createIonLabelRequiredTemplateVisitorClass('ion-item-divider');
+
+export class Rule extends Lint.Rules.AbstractRule {
+  public static metadata: Lint.IRuleMetadata = {
+    ruleName: ruleName,
+    type: 'functionality',
+    description: 'The ion-item-divider component requires an ion-label component. It is no longer automatically added.',
+    options: null,
+    optionsDescription: 'Not configurable.',
+    typescriptOnly: false,
+    hasFix: true
+  };
+
+  public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
+    return this.applyWithWalker(
+      new NgWalker(sourceFile, this.getOptions(), {
+        templateVisitorCtrl: TemplateVisitor
+      })
+    );
+  }
+}

test/ionItemDividerIonLabelRequired.spec.ts

@@ -0,0 +1,80 @@
+import { ruleName } from '../src/ionItemDividerIonLabelRequiredRule';
+import { assertAnnotated, assertSuccess } from './testHelper';
+
+describe(ruleName, () => {
+  describe('success', () => {
+    it('should work with ion-label child', () => {
+      let source = `
+      @Component({
+        template: \`
+          <ion-item-divider>
+            <ion-thumbnail slot="start">
+              <img src="http://pngimg.com/upload/dog_png2402.png">
+            </ion-thumbnail>
+            <ion-label>Dog</ion-label>
+          </ion-item-divider>
+        \`
+      })
+      class Bar{}
+        `;
+      assertSuccess(ruleName, source);
+    });
+
+    it('should work with single ion-label child', () => {
+      let source = `
+      @Component({
+        template: \`
+          <ion-item-divider>
+            <ion-label>Dog</ion-label>
+          </ion-item-divider>
+        \`
+      })
+      class Bar{}
+        `;
+      assertSuccess(ruleName, source);
+    });
+  });
+
+  describe('failure', () => {
+    it('should fail when ion-label missing', () => {
+      let source = `
+      @Component({
+        template: \`
+          <ion-item-divider>
+           ~~~~~~~~~~~~~~~~
+            <ion-thumbnail slot="start">
+              <img src="http://pngimg.com/upload/dog_png2402.png">
+            </ion-thumbnail>
+            Dog
+          </ion-toolbar>
+        \`
+      })
+      class Bar{}
+          `;
+
+      assertAnnotated({
+        ruleName,
+        message: 'The ion-item-divider requires an ion-label component. It is no longer automatically added.',
+        source
+      });
+    });
+
+    it('should fail with only text', () => {
+      let source = `
+      @Component({
+        template: \`
+          <ion-item-divider>Dog</ion-item-divider>
+           ~~~~~~~~~~~~~~~~
+        \`
+      })
+      class Bar{}
+          `;
+
+      assertAnnotated({
+        ruleName,
+        message: 'The ion-item-divider requires an ion-label component. It is no longer automatically added.',
+        source
+      });
+    });
+  });
+});