Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support multiple project parameters in the Cli tool #116

Merged
merged 9 commits into from Oct 10, 2023
Merged

support multiple project parameters in the Cli tool #116

merged 9 commits into from Oct 10, 2023

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Oct 10, 2023 •
edited

fixes #113

@dawedawe dawedawe requested a review from nojaf October 10, 2023 13:13
nojaf
nojaf approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm wondering a bit about the parallel stuff.

src/FSharp.Analyzers.Cli/Program.fs Outdated
return results |> Option.map (printMessages failOnWarnings)
}

projects |> List.map runProj |> Async.Sequential |> Async.RunSynchronously
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we don't want to run these in parallel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm worried about mangled console output.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid concern, although we probably want to be a bit more clever about this eventually.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can wrap it in a lock/mailboxprocessor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe eventually ILogger/ILoggerFactory support but not sure how much worse that would make binary compatibility issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TheAngryByrd , I'd prefer to handle that in a separate PR.

src/FSharp.Analyzers.Cli/Program.fs Outdated
@@ -131,16 +131,23 @@ let printMessages failOnWarnings (msgs: Message list) =

msgs

let calculateExitCode failOnWarnings (msgs: Message list option) : int =
let calculateExitCode failOnWarnings (msgs: Message list option array) : int =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not flatten this collection earlier? This type of definition is getting out of hand.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, good call

@dawedawe dawedawe merged commit 0287d9a into ionide:master Oct 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAngryByrd TheAngryByrd TheAngryByrd left review comments

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multiple project parameters in the Cli tool
3 participants
@dawedawe @TheAngryByrd @nojaf