Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RequireQualifiedAccess to Severity type #199

Merged
merged 1 commit into from Jan 26, 2024

Conversation

Smaug123
Copy link
Contributor

We currently export the DU case Error, which clashes with FSharp.Core's Result.Error. This change means we never conflict with FSharp.Core. The change is source-incompatible, so it will require a release note.

@nojaf
Copy link
Contributor

nojaf commented Jan 26, 2024

Could you check https://github.com/ionide/FSharp.Analyzers.SDK/blob/main/docs/content/Getting%20Started%20Writing.fsx ?
It probably needs a change as well.

@Smaug123
Copy link
Contributor Author

Yep, thanks - I can't run this locally easily because I don't have net7 installed, so I'm using GitHub to do it (sorry).

@nojaf
Copy link
Contributor

nojaf commented Jan 26, 2024

Hmm, fsdocs-tool should be net6.0 though. Perhaps you need 7 for other stuff.

@Smaug123
Copy link
Contributor Author

The specific reason is this line. But I'm happy now that this PR is ready.

Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nojaf nojaf merged commit b0421e3 into ionide:main Jan 26, 2024
2 checks passed
@Smaug123 Smaug123 deleted the rqa-severity branch January 26, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants