Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify sdk version #72

Merged
merged 2 commits into from Sep 6, 2023
Merged

Verify sdk version #72

merged 2 commits into from Sep 6, 2023

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Sep 4, 2023

It can be very confusing when your analyzer is targeting the wrong SDK and gets loaded anyway by the cli tool. I propose to enforce using the correct version instead.

@TheAngryByrd TheAngryByrd self-requested a review September 5, 2023 13:42
Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@TheAngryByrd TheAngryByrd merged commit c3895b0 into ionide:master Sep 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants