Use fantomas for formatting #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
reviewed
Sep 8, 2023
Comment on lines
+126
to
+128
| dotnet fantomas . | ||
| dotnet build -c Release | ||
| dotnet run --project src/FSharp.Analyzers.Cli/FSharp.Analyzers.Cli.fsproj -- --project ./samples/OptionAnalyzer/OptionAnalyzer.fsproj --analyzers-path ./samples/OptionAnalyzer/bin/Release --verbose |
There was a problem hiding this comment.
As an aside, this is what frustrates me about not having a build script. "Remember to do all these steps we gotta keep in sync with our CI yml that we're totally gonna remember to keep in sync"
There was a problem hiding this comment.
Would you be game for https://github.com/slaveOftime/Fun.Build?
There was a problem hiding this comment.
We can give it a try. cc @baronfel
There was a problem hiding this comment.
@nojaf floated this to me the other day - I'm ok with it, but lacking FSX script caching makes me sad. I'd prefer generally to push data/tasks into MSBuild targets as much as possible because that doesn't require any additional tooling. I understand that not everyone feels the same, however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check formatting during CI.
I took some settings from the G-Research style guide. Call it a guilty pleasure.