Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreclr support #100

Closed
kjnilsson opened this issue Mar 24, 2016 · 7 comments
Closed

coreclr support #100

kjnilsson opened this issue Mar 24, 2016 · 7 comments

Comments

@kjnilsson
Copy link
Contributor

Hi

There is a branch of FCS for coreclr support - no idea if it works or not .

Has anyone been trying to update fsac to work against this code?

Cheers
Karl

@Krzysztof-Cieslak
Copy link
Member

Please check ionide/ionide-vscode-fsharp#78. @7sharp9 has already working version of CoreCLR compiled FSAC.

@7sharp9
Copy link
Contributor

7sharp9 commented Jun 23, 2016

@kjnilsson Yeah it works, I have vscode running with dotnetcore

@enricosada
Copy link
Contributor

As a note, now is easier with .NET Core Sdk rc4 to add .net core support than previously with project.json

ref https://github.com/dotnet/netcorecli-fsc/wiki/.NET-Core-SDK-rc4

  • fsprj based, no more project.json
  • fsharp.core v4.1.0 pkg support netstandard
  • side by side with old fsproj, can share props files too (compiler define?)

@Korbin73
Copy link

Korbin73 commented Mar 3, 2017

@7sharp9 Have you trying running it against .NET-Core-SDK-rc4 yet? Particularly with aspnetcore?

@enricosada
Copy link
Contributor

@Korbin73 yes works, see https://github.com/dotnet/netcorecli-fsc/wiki/.NET-Core-SDK-rc4#ide-support for info about rc4. Aspnet works, is just a console app

@Korbin73
Copy link

Korbin73 commented Mar 4, 2017

Thanks for the help @enricosada. Unfortunately, after making the changes to fsproj listed in the section for ide support, the results were still the same https://gist.github.com/Korbin73/c00fd24bcc6eefa964398e012eb41dca
screenshot from 2017-03-02 19-29-37

@kjnilsson
Copy link
Contributor Author

This issue is from my POV complete. Yes there is more work needed to cover the influx of changes in dotnet core support but right now it works. Re-open if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants