Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many errors on textDocument/documentHighlight & textDocument/signatureHelp #833

Closed
s-kostyaev opened this issue Sep 23, 2021 · 3 comments · Fixed by #1069
Closed

Too many errors on textDocument/documentHighlight & textDocument/signatureHelp #833

s-kostyaev opened this issue Sep 23, 2021 · 3 comments · Fixed by #1069

Comments

@s-kostyaev
Copy link

Language server generates too many errors on textDocument/documentHighlight and textDocument/signatureHelp and it's very noisy. Do we need this error notifications?
fsac-lsp-log.txt
fib.fsx.txt

s-kostyaev pushed a commit to s-kostyaev/lsp-mode that referenced this issue Sep 23, 2021
yyoncho pushed a commit to emacs-lsp/lsp-mode that referenced this issue Sep 24, 2021
workaround for ionide/FsAutoComplete#833

Co-authored-by: Sergey Kostyaev <s.kostyaev@omp.ru>
@d4h0
Copy link

d4h0 commented Feb 19, 2023

This makes fasautocomplete basically unusable without some kind of workaround.

In neovim I get 'No symbol information found' error messages on almost every cursor move. No other LSP server I've used behaves this way, so this seems to be an issue with fasautocomplete.

I've tried to figure out how to fix this, but I haven't even started to learn F# (at the moment, I struggle setting up a usable F# dev environment), so I'm probably not the best person to work on this.

@vain0x
Copy link
Contributor

vain0x commented Feb 23, 2023

On documentHighlight: The server will send an InternalError error response instead of successful response with result null when requested position isn't at a symbol.

In code: The "No symbol" error is generated here.
It's converted here to an internal error response.
This pattern (raising an Error instead of empty) appears in other cases too.

@haodeon
Copy link
Contributor

haodeon commented Feb 23, 2023

My workaround for Neovim is to disable the autocmd group for documentHighlight when the LSP client name is fsautocomplete.

Otherwise the error behaviour makes Neovim terrible to use with the constant error spam from moving the cursor around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants