Fix removeCommaEdits in ConvertPositionalDUToNamed to work for unformatted patterns #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For unformatted patterns like (a,b) the left edge of the b range should be left out when checking if the comma pos is inside a pattern range
|
Good spot 👍 |
dawedawe
deleted the
fix_ConvertPositionalDUToNamed_when_unformated_pattern
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recording.2023-03-12.205242.mp4
For unformatted patterns like (a,b) (please note the missing space after the coma) the left edge of the b range should be left out when checking if the comma pos is inside a pattern range. Otherwise the removeCommaEdits don't remove the comma and invalid syntax is produced, see video.