Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tool paths returned for the netcore host in line with full-framework #305

Merged

Conversation

baronfel
Copy link
Contributor

even though FSAC is running on netcore, the tools it returns back should probably be full-framework compatible until we get to a spot where tooling can tell fsac where compilers/corelibs are.

This makes it so that non-windows, netcore users of FSAC get the same compiler binaries returned as non-windows, mono users of FSAC. This enables ionide to trust the responses received from FSAC instead of having to probe on its own.

Before (mono):

➜  bin git:(master) ✗ mono fsautocomplete.exe
compilerlocation
{"Kind":"compilerlocation","Data":{"Fsc":"fsharpc","Fsi":"fsharpi","MSBuild":"xbuild"}}

Before(netcore):

➜  bin_netcore git:(master) ✗ dotnet fsautocomplete.dll
compilerlocation
{"Kind":"compilerlocation","Data":{"Fsc":"fsc.exe","Fsi":"fsi.exe","MSBuild":"msbuild"}}

After(mono):

➜  bin git:(master) ✗ mono fsautocomplete.exe
compilerlocation
{"Kind":"compilerlocation","Data":{"Fsc":"fsharpc","Fsi":"fsharpi","MSBuild":"msbuild"}}

After(netcore):

➜  netcoreapp2.0 git:(netcore_binary_paths) ✗ dotnet fsautocomplete.dll
compilerlocation
{"Kind":"compilerlocation","Data":{"Fsc":"fsc.exe","Fsi":"fsharpi","MSBuild":"msbuild"}}

@Krzysztof-Cieslak Krzysztof-Cieslak merged commit 417ecd0 into ionide:fcs_20180726 Aug 17, 2018
@baronfel
Copy link
Contributor Author

@Krzysztof-Cieslak you got those firey fingers 👍 I'll integrate this update into the MR I'm working on for ionide

@baronfel baronfel deleted the netcore_binary_paths branch August 17, 2018 20:50
Krzysztof-Cieslak pushed a commit that referenced this pull request Sep 5, 2018
Krzysztof-Cieslak pushed a commit that referenced this pull request Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants