Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the same non-windows msbuild check that we do for fsc and fsi #306

Merged

Conversation

baronfel
Copy link
Contributor

One more, I somehow missed msbuild:

before(dotnet):

➜  release_netcore git:(417ecd0) ✗ dotnet fsautocomplete.dll
compilerlocation
{"Kind":"compilerlocation","Data":{"Fsc":"fsharpc","Fsi":"fsharpi","MSBuild":"MSBuild.exe"}}

before(mono):

➜  release_netcore git:(417ecd0) ✗ cd ../release
➜  release git:(417ecd0) ✗ mono fsautocomplete.exe
compilerlocation
{"Kind":"compilerlocation","Data":{"Fsc":"fsharpc","Fsi":"fsharpi","MSBuild":"msbuild"}}

after(dotnet):

➜  FsAutoComplete.netcore git:(fix-netcore-msbuild-path) dotnet run
compilerlocation
{"Kind":"compilerlocation","Data":{"Fsc":"fsharpc","Fsi":"fsharpi","MSBuild":"msbuild"}}

after(mono):

➜  net461 git:(fix-netcore-msbuild-path) mono fsautocomplete.exe
pilerlocation
{"Kind":"compilerlocation","Data":{"Fsc":"fsharpc","Fsi":"fsharpi","MSBuild":"msbuild"}}

@baronfel
Copy link
Contributor Author

All the errors seem to be around a paket-load-script rewrite issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants