Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace project system, use Dotnet.ProjInfo.Workspace #347

Merged
merged 3 commits into from
Jun 7, 2019

Conversation

enricosada
Copy link
Contributor

@enricosada enricosada commented Mar 1, 2019

Use Dotnet.ProjInfo.Workspace.FCS from https://github.com/enricosada/dotnet-proj-info/

  • use workspace loader to parse a workspace (projects/sln)
  • remove projectcracker, replaced by Dotnet.ProjInfo.Workspace.FCS
  • use Dotnet.ProjInfo.Workspace.ProjectViewer to render source files tree in solution explorer
  • drop project.json support, long live the king!
  • remove msbuild buildtools not needed anymore
  • remove nofsharpcore support, the FSharp.Core assembly must be referenced in old sdk fsproj

Replace environment info (like msbuild locations or .NET Framework version installed) with info provided by Dotnet.ProjInfo.Workspace library

@Krzysztof-Cieslak
Copy link
Member

@enricosada let's merge this.

@enricosada
Copy link
Contributor Author

Yes, i'll rebase and merge

- use workspace loader to parse projects
- remove projectcracker
- drop project.json support
- buildtools not needed anymore
- remove nofsharpcore support
- use Dotnet.ProjInfo.Workspace.ProjectViewer to render source files
@enricosada enricosada changed the title use Dotnet.ProjInfo.Workspace replace project system, use Dotnet.ProjInfo.Workspace Jun 7, 2019
@enricosada enricosada merged commit 4b54fbe into ionide:master Jun 7, 2019
@Krzysztof-Cieslak
Copy link
Member

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants