Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Uri instead of FileName for several fsharp/ requests #949

Merged
merged 5 commits into from
May 29, 2022
Merged

Use Uri instead of FileName for several fsharp/ requests #949

merged 5 commits into from
May 29, 2022

Commits on May 28, 2022

  1. Use Uri instead of filename for fsharp/FileParsed

    @Booksbaum
    Booksbaum committed May 28, 2022
    Configuration menu
    Copy the full SHA
    163d78b View commit details
    Browse the repository at this point in the history

  2. Fix: Off-by-One column in fsharp/documentation 

    In Ionide: used for Info Panel
    @Booksbaum
    Booksbaum committed May 28, 2022
    Configuration menu
    Copy the full SHA
    24014c4 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2022

  1. Fix: Off-by-One column in fsharp/f1Help

    @Booksbaum
    Booksbaum committed May 29, 2022
    Configuration menu
    Copy the full SHA
    81a891d View commit details
    Browse the repository at this point in the history

  2. Change FSharpPipelineHintRequest to use Uri 

    Change `HighlightingRequest`, `FSharpLiterateRequest` to use Uri too
* But neither of these two is actually used

Note: This commit results in changed API:
* Prev: `{ FileName: string }`
* Now: `{ TextDocument: TextDocumentIdentifier }`
-> Clients must be adjusted
    @Booksbaum
    Booksbaum committed May 29, 2022
    Configuration menu
    Copy the full SHA
    db21512 View commit details
    Browse the repository at this point in the history

  3. Format Code

    @Booksbaum
    Booksbaum committed May 29, 2022
    Configuration menu
    Copy the full SHA
    4513468 View commit details
    Browse the repository at this point in the history