Add types around workspace folders support #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks for contributing the types for this! |
baronfel
reviewed
Apr 26, 2022
The main parts are: 1. Having WorkspaceFolders in InitializeParams as it supersedes rootPath and rootUri 2. Having workspace folders server capability.
artempyanykh
force-pushed
the
workspace-folders-caps
branch
from
c96daff
to
4ba9a67
Compare
|
I marked this to merge when the checks complete, and I'll be pushing out a new version of this repo hopefully this week so you don't have to submodule anymore. |
|
0.4.0 has been released! go forth and update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main parts are:
I've tested this in my server, and it seems to work.