[RFC] Workaround a VSCode bug that precludes the server from exiting #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome stuff, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCode language client doesn't properly send an exit notification to the server; so when the server is restarted or the window is reloaded currently running server turns into a zombie... and after a while we have a zombie party.
I see that FSAC has its own workaround where it tries to monitor the parent process. That solution is local to the actual server and doesn't require changes in the library.
Another solution is to add a bit of logic into the library which may not be as clean, but it'd relieve the servers from needing to re-invent a workaround to the bug.