Add InlayHint (LSP 3.17)
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: [`LSPAny`](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#lspAny) in LSP is: ```typescript export type LSPAny = LSPObject | LSPArray | string | integer | uinteger | decimal | boolean | null; export type LSPObject = { [key: string]: LSPAny }; export type LSPArray = LSPAny[]; ``` which I simplified to `JToken` Note: [InlayHintProvider](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#serverCapabilities) in LSP: ```typescript inlayHintProvider?: boolean | InlayHintOptions | InlayHintRegistrationOptions; ``` Based on other existing provider capabilities, I just use `bool option`. I created neither [`InlayHintOptions`](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#inlayHintOptions) nor [`InlayHintRegistrationOptions`](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#inlayHintRegistrationOptions).
4 tasks
|
I added the InlayHintOptions because it's very easy right now and it prepares us for if they add properties in the future, but otherwise this looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
LSPAnyin LSP is:which I simplified to
JTokenNote: InlayHintProvider in LSP:
Based on other existing provider capabilities, I just use
bool option.I created neither
InlayHintOptionsnorInlayHintRegistrationOptions.