Handle non-async exceptions from LSP handlers #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lgtm! |
|
LGTM, thanks for doing this. Do you want a release while we figure out what to do about the ordering question? |
|
No problem!
@baronfel I'm still vendoring the lib, so having an actual release is not super critical. |
artempyanykh
added a commit
to artempyanykh/LanguageServerProtocol
that referenced
this pull request
Jul 31, 2022
This is once again a continuation of ionide#25. There were several issues with the previous version. Catching exceptions in server's code and turning them into LocalRpcExceptions probably isn't the best because: 1. Notifications don't require a response, hence no error will be shown to the user. Effectively, this means any exceptions including fatal can get swallowed. 2. The context of the original exception is lost in conversion.
baronfel
pushed a commit
that referenced
this pull request
Jul 31, 2022
This is once again a continuation of #25. There were several issues with the previous version. Catching exceptions in server's code and turning them into LocalRpcExceptions probably isn't the best because: 1. Notifications don't require a response, hence no error will be shown to the user. Effectively, this means any exceptions including fatal can get swallowed. 2. The context of the original exception is lost in conversion.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the discussion in #24
The ordering is back to normal and exceptions are returned to the client as errors and shown to the user.