Remove spurious whitespace in workspace/executeCommand handler #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OMFG that explains so much about my own experiments with workspace commands. |
|
Thanks for the Fastest Merge In The West! |
|
I'll try to get a release out later today US Eastern Time with this fix. |
|
👍 even though I'm using it as a vendored dependency, it's a good idea to not have a stable version anywhere with this bug :D |
|
Selfishly I want it available for FSAC. We don't use a vendored dependency in part to encourage me to quickly make releases here :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting
No method by the name 'workspace/executeCommand' is found.even though I registered all the providers correctly.This seems like a good candidate for a reason why :)