Add textDocument/prepareRename request #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: the type of response is not modelled fully as it's a bit involved. I hope supporting additional response shapes can be done in a follow up if needed.
|
|
notImplemented cannot be used because the server will fail on rename.
None cannot be used because it marks an invalid rename.
We need to respond with a {defaultBehavior=true} so that those servers
that didn't override prepareRename still have the same rename behavior
as before.
NOTE: I needed to model the response fully to make things work.
|
Nice! We really do need a better way to handle things like WorkDoneProgressParams, but this is a general failing of this library at the moment. |
artempyanykh
added a commit
to artempyanykh/LanguageServerProtocol
that referenced
this pull request
Aug 7, 2022
This is a continuation to ionide#30. Apparently, nvim and emacs treat rename capabilities a bit differently which is why I didn't notice the problem before I tried using Marksman with Emacs.
baronfel
pushed a commit
that referenced
this pull request
Aug 7, 2022
This is a continuation to #30. Apparently, nvim and emacs treat rename capabilities a bit differently which is why I didn't notice the problem before I tried using Marksman with Emacs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepareRenamewith a range response allows rename to work reasonably with Markdown symbols that can contain whitespace and other kinds of punctuation. Also, makes rename behave better on invalid positions (instead of new name prompt followed by a no-op rename the user gets 'no rename' and no prompt).Description in LSP spec: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_prepareRename