Allow multiple instances of the server on a single process.

[TrevorThoele2]

Addresses issue.

Allows singleton json formatter for serialize/deserialize.

startWithSetup creates json formatter each time.

[baronfel]

Thanks for the issue, triage, and PR! Happy to take this and release a new version once the tests are green. It looks like CI is having some trouble with the new ones at the moment.

[zZeck]

let requestWithContentLength(request: string) = $"Content-Length: {request.Length}\r\n\r\n{request}"

git can convert newlines in files, and since this is a string literal, it caused a problem when the underlying file bytes changed. It was coded on windows which is \r\n, but got converted to unix line endings on push which is \n only. The json rpc stream requires \r\n.

Their error message is actually bugged. They don't escape the slashes in their string so it prints an actual newline where they intended to print "\r\n". I'll probably make a PR over there.

Also note it can't be a @ literal string now, or that would literally put \r\n in the string instead of escaping and putting the return and new line bytes.

[zZeck]

I just notice with Utils.Tests being here, maybe StartWithSetup.tests should be too, rather than at the end of the serializationTests. Dunno what maintainers want.
let tests = testList "LSP" [ serializationTests; Utils.tests; StartWithSetup.tests ]

[TrevorThoele2]

Apologies, I believe this PR should now pass the tests. Let me know if there's anything more that I need to do.

[baronfel]

Awesome! Thanks for the contribution, we'll try and get a new version out quickly.

[baronfel]

If you don't mind me asking @TrevorThoele2 / @zZeck - what are y'all using the library for? I'm always interested in knowing more about who the users are (aside from FSAC, naturally :) )

[TrevorThoele2]

@baronfel We are working on creating a project we call the "state space analysis tool" for C#. We think it would be useful to see the state space of variables, functions and classes (any C# component, really) as it is declared, as the state space implicitly changes at call sites, and then aggregated state space across all usages of components. This is what we believe we are doing at some level whenever we simplify our code. Having a tool that can display this information automatically by hovering over a component in a file while working would allow quicker-to-access edits/refactorings while keeping the same overall topology/functionality of the component in question.

Essentially, calculable information displayed to the user in a VS Code extension by hovering is what we're after right now.

Here is the link to the GitHub repository if you are interested: https://github.com/TrevorThoele2/poke.

[baronfel]

That sounds awesome, very interested in taking a look.

It looks like the release pipeline didn't kick off as expected, let me try to get that going again.

[baronfel]

There we go, 0.4.15 is published on NuGet.org!

[TrevorThoele2]

I have pulled that version into our project and the tests are passing in the ways I expect them to. Thank you for your help, we really appreciate it! This is a very good and useful project for us and we appreciate that as well.