Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WorkDoneProgressCancel arguments #58

Merged
merged 1 commit into from Oct 29, 2023
Merged

Fix WorkDoneProgressCancel arguments #58

merged 1 commit into from Oct 29, 2023

Conversation

TheAngryByrd
Copy link
Member

@TheAngryByrd TheAngryByrd commented Oct 29, 2023 •
edited by ghost

WHAT

🤖 Generated by Copilot at 9196122

Updated the WorkDoneProgressCancel method to match the latest LSP specification and handle optional cancellation tokens. Renamed some parameters for readability.

🤖 Generated by Copilot at 9196122

Sing, O Muse, of the valiant LspServer and its deeds
That followed the wise words of the LSP oracle
And changed its WorkDoneProgressCancel method with speed
To match the new WorkDoneProgressCancelParams protocol

🔄📝🛠️

WHY

Using incorrect parameter see the spec

HOW

🤖 Generated by Copilot at 9196122

  • Update WorkDoneProgressCancel method parameter type to WorkDoneProgressCancelParams in ILspServer interface and LspServer class (link, link)
  • Rename token parameter to p in WorkDoneProgressCancel method in LspServer class (link)

@baronfel baronfel merged commit 40e3453 into ionide:main Oct 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheAngryByrd @baronfel