Fix: Several commands don't work in untitled docs #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: filename instead of uri was used
Update `fsharp/signatureData` and `fsharp/lineLens` to use uri Update LineLense to use uri instead of filename for caching Fix: InfoPanel, LineLense, PipelineHint, QuickInfo don't get updated after file parsed in untitled doc (LineLense didn't even get created because of this) Note: requires a patch for FSAC: `fsharp/fileParsed` must contain uri instead of filename Note: `Notifications.DocumentParsedEvent.uri` is just `string` instead of `DocumentUri`: Is before definition of `DocumentUri` and no `rec` & `let mutable` together allowed -> `string` is kept (instead of some code restructure)
Change `HighlightingRequest`, `FSharpLiterateRequest`, `FSharpPipelineHintsRequest` to use Uri instead of FileName * Note: Requires updated FSAC with matching changes for these requests Note: `HighlightingRequest` isn't actually used (method with request exist, but is never called) Additional: Not handled in FSAC Note: `FSharpLiterateRequest` is currently uncommented in FSAC -> not handled in FSAC
|
These are great - there's a sort of long-standing problem that you're touching on her where many of the custom endpoints use non-LSP structures and as a result are prone to this sort of error. I'll take a detailed look today! |
|
I've tested this locally this morning and both sets of changes are good. Thank you (yet again!) for smoothing out the rough corners of these projects. I'll merge both and get a release with these fixes out today! Getting contributions like this is incredibly motivating for me personally, thank you for taking the time to make FSAC and Ionide better :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several commands don't work in untitled docs because they use FileName instead of URI:
F1 Help, Info Panel, Quick Info, Line Lense, Pipeline Hints
These are not just Ionide fixes, but require changes in FSAC too: ionide/FsAutoComplete#949
Additional fix: