Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Msbuildproperties #1832

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

TheAngryByrd
Copy link
Member

@TheAngryByrd TheAngryByrd commented Feb 26, 2023

Corresponding PR for https://github.com/fsharp/FsAutoComplete/pull/1065/files

WHAT

馃 Generated by Copilot at 1ff8aec

This pull request enhances the F# language service configuration and observability in VS Code. It adds new options for release/package.json to control various aspects of the language service, and enables OpenTelemetry tracing for src/Core/LanguageService.fs and FsAutoComplete.

馃 Generated by Copilot at 1ff8aec

The F# language service got some tweaks
To customize its MSBuild and speaks
You can now trace and notify
With OpenTelemetry
And also remove some whitespaces that sneak

馃敡馃搳馃殌

WHY

HOW

馃 Generated by Copilot at 1ff8aec

  • Add configuration options for MSBuild properties, notifications and tracing, and OpenTelemetry exporter (link, link, link, link)
  • FSharp.buildOptions.msBuildProperties allows customizing the design time load of F# projects in release/package.json (link)
  • FSharp.notifications.trace, FSharp.notifications.traceNamespaces, and FSharp.openTelemetry.enabled enable verbose notifications and tracing using System.Diagnostics.Activity and OpenTelemetry in release/package.json (link)
  • FSharp.openTelemetry.enabled is read by the getOptions function in src/Core/LanguageService.fs and passed to the spawnNetCore function as --otel-exporter-enabled argument (link, link)
  • Remove trailing whitespaces from FSharp.fsac.conserveMemory and FSharp.fsac.parallelReferenceResolution options in release/package.json (link, link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant