Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keybinding to fsharp.explorer.renameFile in F# Solution Explorer #1931

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Sep 15, 2023

WHAT

馃 Generated by Copilot at d091901

Add keybinding for file renaming and fix JSON formatting. This pull request enhances the usability of the F# project explorer by allowing users to rename files with a keyboard shortcut. It also corrects a misplaced comma in release/package.json.

馃 Generated by Copilot at d091901

If you want to rename files with ease
In the F# project explorer, please
Use the new keybinding
That this PR is finding
And also fix the JSON with s

馃摑馃敡馃尡

WHY

I thought this would be a quick one, but apparently I'm missing some background story here why this doesn't work with such a simple change. Does anyone know why?

HOW

馃 Generated by Copilot at d091901

  • Add a keybinding for renaming files in the project explorer view (link)
  • Ensure the JSON file has a valid format by adding a closing curly brace and a newline at the end of release/package.json (link)

@dawedawe dawedawe marked this pull request as draft September 15, 2023 07:22
@TheAngryByrd
Copy link
Member

I thought this would be a quick one, but apparently I'm missing some background story here why this doesn't work with such a simple change. Does anyone know why?

We seem to have "command": "fsharp.explorer.renameFile" twice in that file. Maybe that's causing it?

@dawedawe
Copy link
Contributor Author

Mmh, no, seems to be something else. I'll do some more digging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants