-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph Build on FsToolkit.ErrorHandling reports projects with no Items. #109
Comments
I was able to recreate this issue in one of my projects, where having |
I looked into this a bit tonight and I'm kind of stumped. When running the build code: proj-info/src/Ionide.ProjInfo/Library.fs Lines 436 to 443 in ecb0ed9
Failure and a null Exception. When digging into the ResultsByTarget, it shows that CoreCompile target is the one failing on all projects. However, I do not encounter this build failure when reverting to 5.0.103 , only on 5.0.201 . Without a good error message, I'm going to be stuck in the mud here. Maybe @cartermp has some deep lore that can point me in a good direction.
Currently the only work around I have is either turn off project graph, or use |
Hmm, that sounds like there might be a bug in the SDK or MSBuild, offhandedly. We didn't change anything in the F# compiler AFAIK. |
So I wasn't looking into the
It looks like it's trying to use a windows executable on macos. Any pointers? |
I thought we've already fixed it #100 |
Doesn't look like it's "Build" proj-info/src/Ionide.ProjInfo/Library.fs Lines 98 to 101 in ecb0ed9
|
Switching |
I think the core fix was https://github.com/ionide/proj-info/pull/100/files#diff-44471b59d78aad3cf24d57a7b262f424f22d24d33090ace15bf5ce8345d4a53fR88-R92 Is it also done for GraphLoader? |
Hmm I added this right before it builds but had no difference. match System.Environment.GetEnvironmentVariable "DOTNET_HOST_PATH" with
| null
| "" -> System.Environment.SetEnvironmentVariable("DOTNET_HOST_PATH", Ionide.ProjInfo.Paths.dotnetRoot)
| _alreadySet -> () Maybe there's some deep property I gotta mangle in BuildParameters or GraphBuildRequestData? |
I recently bumped FSAC to 5.0.2xx and the graph build failures appeared in the test suite we have there too, so there's another touchstone at least. |
closed by #111 |
Describe the bug
When opening FsToolkit.ErrorHandling at commit
f09472a88a6f7032b1f6eaf7961454f91c992870
in Ionide 5.5.3 with"FSharp.enableMSBuildProjectGraph": true
set, the projects cracked contain no items. ThenotifyWorkspace
notifications from FSAC look like:for example.
Expected behaviour
Projects cracked should contain items.
The project does work/build with using
dotnet build -graph
on the command line, and checking the structured build log shows that the SourceFiles are in fact being passed to theCoreCompile
/Fsc
targets as expected.The text was updated successfully, but these errors were encountered: