-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easier API to get project options #16
Comments
@enricosada Any thoughts on this? I have to copy the MangelMaxime/Thoth#17 |
pratically that file does two things:
i think i can add these as feature to this library:
i dont like to add a reference to FCS just for the projectcracker type (anyway is really dumb data). I'll do that @alfonsogarciacaro so you dont need that file anymore (so less moving bugfixes around). |
sry @alfonsogarciacaro didnt see before the issue |
No worries, I just wanted to ping you because the notification might have gone unnoticed :) It'd be really helpful if you could add the features to the library, thank you! But I agree you shouldn't add the FCS dependency just for the type. For me, it'd be enough to have an interface with the same properties and I can do the conversion in my code :) |
ref #16 Extract FSAC code for loading (fsproj and fsx) and package in a nice to use library (`Dotnet.ProjInfo.Workspace`), plus features and cleanup. Features: - notifications for loading/loaded/failed - same fsc info (fsc args etc) - traverse all projects (like f# -> c# -> f#) - allow configure msbuild (msbuild.exe or dotnet msbuild) - api for fsx - cached projs by target framework - removed the helper target file in `obj` dir - easier way to test scenarios ( `test/Dotnet.ProjInfo.Workspace.Tests` ) - support old fsproj (verbose) and .NET sdk fsproj (slim) both using Out Of Process msbuild (no msbuild libs as deps) Add `Dotnet.ProjInfo.Workspace.FCS` with helper functions to use with FSharp.Compiler.Service part of the code is from ionide/FsAutoComplete@7ed9a0b
Fable is using Dotnet.ProjInfo and it's working really well, thank you! However, I'm concerned that I need to keep this file in my repo. It's mainly copied from Ionide (or FSAC, I don't remember) and it's also working fine. But the code is not trivial and has some slight modifications, so I'm afraid it can easily break and/or become outdated soon and it won't be easy to keep it up-to-date.
It'd be great if there was a simple function exposed by Dotnet.ProjInfo to which I could pass the .fsproj file path and get the Project options without the extra boilerplate.
The text was updated successfully, but these errors were encountered: