Port to Ionide.KeepAChangelog #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. Thoughts on putting the packaging props into a |
baronfel
reviewed
Feb 14, 2022
| @@ -126,14 +98,12 @@ Target.create | |||
| "Pack" | |||
| (fun _ -> | |||
| let properties = | |||
| [ ("Version", nugetVersion) | |||
| ("Authors", authors) | |||
| [ ("Authors", authors) | |||
| ("PackageProjectUrl", gitUrl) | |||
| ("PackageTags", tags) | |||
| ("RepositoryType", "git") | |||
There was a problem hiding this comment.
these source control properties can be removed - sourcelink/dotnet.reproducible builds infer them correctly for you.
baronfel
reviewed
Feb 14, 2022
| ("PackageProjectUrl", gitUrl) | ||
| ("PackageTags", tags) | ||
| ("RepositoryType", "git") | ||
| ("RepositoryUrl", gitUrl) | ||
| ("PackageLicenseExpression", "MIT") | ||
| ("PackageReleaseNotes", packageReleaseNotes) | ||
| ("PackageDescription", summary) | ||
| ("EnableSourceLink", "true") ] |
There was a problem hiding this comment.
this one can be removed as well - sourcelink is just auto-on with the dotnet.reproduciblebuild package.
baronfel
reviewed
Feb 14, 2022
| @@ -126,14 +98,12 @@ Target.create | |||
| "Pack" | |||
| (fun _ -> | |||
| let properties = | |||
| [ ("Version", nugetVersion) | |||
| ("Authors", authors) | |||
| [ ("Authors", authors) | |||
| ("PackageProjectUrl", gitUrl) | |||
There was a problem hiding this comment.
you can remove this project url as well - it defaults to the repo git url that sourcelink derives from the origin uri
knocte
added a commit
to knocte/proj-info
that referenced
this pull request
Mar 22, 2022
This reverts commit 921703b.
knocte
added a commit
to knocte/proj-info
that referenced
this pull request
Mar 22, 2022
This reverts commit 921703b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Ionide.KeepAChangelog instead of custom FAKE code.